From 6605658bac05abdb9ceee9f8bc755693a8f67d8f Mon Sep 17 00:00:00 2001 From: "oura.a" Date: Wed, 6 Sep 2023 08:45:44 +0000 Subject: [PATCH] =?UTF-8?q?Merged=20PR=20389:=20IF=E4=B8=8D=E5=85=B7?= =?UTF-8?q?=E5=90=88=E4=BF=AE=E6=AD=A3?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## 概要 [Task2589: IF不具合修正](https://paruru.nds-tyo.co.jp:8443/tfs/ReciproCollection/fa4924a4-d079-4fab-9fb5-a9a11eb205f0/_workitems/edit/2589) パートナー一覧取得APIに以下の不具合があったため修正しました。 ・RoleGuardが誤っている(tier3,tier4が不足) ・パラメータを文字列として受け取ってしまう ※openapi.jsonへ跳ねる修正はありません。 ## レビューポイント なし ## UIの変更 なし ## 動作確認状況 ローカルで動作確認済み(パラメータ受け取り) ## 補足 なし --- dictation_server/src/features/accounts/accounts.controller.ts | 2 +- dictation_server/src/features/accounts/types/types.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/dictation_server/src/features/accounts/accounts.controller.ts b/dictation_server/src/features/accounts/accounts.controller.ts index 1681637..9753144 100644 --- a/dictation_server/src/features/accounts/accounts.controller.ts +++ b/dictation_server/src/features/accounts/accounts.controller.ts @@ -794,7 +794,7 @@ export class AccountsController { @UseGuards( RoleGuard.requireds({ roles: [ADMIN_ROLES.ADMIN], - tiers: [TIERS.TIER1, TIERS.TIER2], + tiers: [TIERS.TIER1, TIERS.TIER2, TIERS.TIER3, TIERS.TIER4], }), ) async getPartners( diff --git a/dictation_server/src/features/accounts/types/types.ts b/dictation_server/src/features/accounts/types/types.ts index 9ce7f7a..9679586 100644 --- a/dictation_server/src/features/accounts/types/types.ts +++ b/dictation_server/src/features/accounts/types/types.ts @@ -388,10 +388,12 @@ export class GetPartnersRequest { @ApiProperty({ description: '取得件数' }) @IsInt() @Min(0) + @Type(() => Number) limit: number; @ApiProperty({ description: '開始位置' }) @IsInt() @Min(0) + @Type(() => Number) offset: number; }