From 756f6155d5e95b7ce06dab5eb507757baf047ab5 Mon Sep 17 00:00:00 2001 From: "saito.k" Date: Tue, 20 Jun 2023 08:06:04 +0000 Subject: [PATCH] =?UTF-8?q?Merged=20PR=20171:=20B2Cservice=E3=81=AE?= =?UTF-8?q?=E3=82=A8=E3=83=A9=E3=83=BC=E3=81=AE=E8=A7=A3=E6=B6=88?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit <内容> - 不要な処理を削除(削除漏れだった箇所) --- dictation_server/src/features/tasks/tasks.service.ts | 1 - dictation_server/src/gateways/adb2c/adb2c.service.ts | 12 +++--------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/dictation_server/src/features/tasks/tasks.service.ts b/dictation_server/src/features/tasks/tasks.service.ts index 175965f..64e5799 100644 --- a/dictation_server/src/features/tasks/tasks.service.ts +++ b/dictation_server/src/features/tasks/tasks.service.ts @@ -142,7 +142,6 @@ export class TasksService { return x.typist_user.external_id; } }); - console.log(assigneesExternalIds.concat(undefined)); //重複をなくす const distinctedExternalIds = [ diff --git a/dictation_server/src/gateways/adb2c/adb2c.service.ts b/dictation_server/src/gateways/adb2c/adb2c.service.ts index 6672a4f..efbf23b 100644 --- a/dictation_server/src/gateways/adb2c/adb2c.service.ts +++ b/dictation_server/src/gateways/adb2c/adb2c.service.ts @@ -200,7 +200,7 @@ export class AdB2cService { const chunkExternalIds = splitArrayInChunksOfFifteen(externalIds); try { - const resArr: AdB2cUser[] = []; + const b2cUsers: AdB2cUser[] = []; for (let index = 0; index < chunkExternalIds.length; index++) { const element = chunkExternalIds[index]; const res: AdB2cResponse = await this.graphClient @@ -208,16 +208,10 @@ export class AdB2cService { .select(['id', 'displayName']) .filter(`id in (${element.map((y) => `'${y}'`).join(',')})`) .get(); - resArr.push(...res.value); + b2cUsers.push(...res.value); } - const data: AdB2cResponse = await this.graphClient - .api(`users/`) - .select(['id', 'displayName']) - .filter(`id in (${externalIds.map((x) => `'${x}'`).join(',')})`) - .get(); - - return data.value; + return b2cUsers; } catch (e) { this.logger.error(e); const { statusCode } = e;