From c31bb47bb8a18b12ff234a9f4aba5381a832d83a Mon Sep 17 00:00:00 2001 From: "maruyama.t" Date: Thu, 22 Feb 2024 07:52:16 +0000 Subject: [PATCH] =?UTF-8?q?Merged=20PR=20773:=20api=E3=81=ABtransfer?= =?UTF-8?q?=E3=81=8C=E5=AD=98=E5=9C=A8=E3=81=97=E3=81=AA=E3=81=8B=E3=81=A3?= =?UTF-8?q?=E3=81=9F=E3=81=AE=E3=82=92=E4=BF=AE=E6=AD=A3?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## 概要 [Task3570: データ変換ツール（きれいなデータ版）作成＋動作確認](https://paruru.nds-tyo.co.jp:8443/tfs/ReciproCollection/fa4924a4-d079-4fab-9fb5-a9a11eb205f0/_workitems/edit/3570) - 元PBI or タスクへのリンク（内容・目的などはそちらにあるはず） - 何をどう変更したか、追加したライブラリなど - このPull Requestでの対象/対象外 - 影響範囲（他の機能にも影響があるか） ## レビューポイント - 特にレビューしてほしい箇所 - 軽微なものや自明なものは記載不要 - 修正範囲が大きい場合などに記載 - 全体的にや仕様を満たしているか等は本当に必要な時のみ記載 ## UIの変更 - Before/Afterのスクショなど - スクショ置き場 ## 動作確認状況 - ローカルで確認、develop環境で確認など ## 補足 - 相談、参考資料などがあれば --- data_migration_tools/server/src/app.module.ts | 21 ++++++++++++++++--- .../features/transfer/transfer.controller.ts | 10 ++++----- .../src/features/transfer/transfer.module.ts | 10 ++++----- .../src/features/transfer/transfer.service.ts | 4 ++-- 4 files changed, 30 insertions(+), 15 deletions(-) diff --git a/data_migration_tools/server/src/app.module.ts b/data_migration_tools/server/src/app.module.ts index 8089b78..6935bba 100644 --- a/data_migration_tools/server/src/app.module.ts +++ b/data_migration_tools/server/src/app.module.ts @@ -24,7 +24,9 @@ import { DeleteModule } from "./features/delete/delete.module"; import { DeleteRepositoryModule } from "./repositories/delete/delete.repository.module"; import { DeleteController } from "./features/delete/delete.controller"; import { DeleteService } from "./features/delete/delete.service"; - +import { TransferModule } from "./features/transfer/transfer.module"; +import { TransferController } from "./features/transfer/transfer.controller"; +import { TransferService } from "./features/transfer/transfer.service"; @Module({ imports: [ ServeStaticModule.forRoot({ @@ -37,6 +39,7 @@ import { DeleteService } from "./features/delete/delete.service"; AdB2cModule, AccountsModule, UsersModule, + TransferModule, RegisterModule, AccountsRepositoryModule, UsersRepositoryModule, @@ -61,8 +64,20 @@ import { DeleteService } from "./features/delete/delete.service"; inject: [ConfigService], }), ], - controllers: [RegisterController, AccountsController, UsersController, DeleteController], - providers: [RegisterService, AccountsService, UsersService, DeleteService], + controllers: [ + RegisterController, + AccountsController, + UsersController, + DeleteController, + TransferController, + ], + providers: [ + RegisterService, + AccountsService, + UsersService, + DeleteService, + TransferService, + ], }) export class AppModule { configure(consumer: MiddlewareConsumer) { diff --git a/data_migration_tools/server/src/features/transfer/transfer.controller.ts b/data_migration_tools/server/src/features/transfer/transfer.controller.ts index 8ac9923..59f90fc 100644 --- a/data_migration_tools/server/src/features/transfer/transfer.controller.ts +++ b/data_migration_tools/server/src/features/transfer/transfer.controller.ts @@ -11,7 +11,7 @@ import fs from "fs"; import { ApiOperation, ApiResponse, ApiTags } from "@nestjs/swagger"; import { Request } from "express"; import { transferRequest, transferResponse } from "./types/types"; -import { transferService } from "./transfer.service"; +import { TransferService } from "./transfer.service"; import { makeContext } from "../../common/log"; import { csvInputFile } from "../../common/types/types"; import { makeErrorResponse } from "src/common/errors/makeErrorResponse"; @@ -24,12 +24,12 @@ import { LICENSE_ALLOCATED_STATUS, USER_ROLES, AUTO_INCREMENT_START, -} from "../../../src/constants"; +} from "../../constants"; @ApiTags("transfer") @Controller("transfer") -export class transferController { - private readonly logger = new Logger(transferController.name); - constructor(private readonly transferService: transferService) {} +export class TransferController { + private readonly logger = new Logger(TransferController.name); + constructor(private readonly transferService: TransferService) {} @Post() @ApiResponse({ diff --git a/data_migration_tools/server/src/features/transfer/transfer.module.ts b/data_migration_tools/server/src/features/transfer/transfer.module.ts index b2a7893..d2d9695 100644 --- a/data_migration_tools/server/src/features/transfer/transfer.module.ts +++ b/data_migration_tools/server/src/features/transfer/transfer.module.ts @@ -1,9 +1,9 @@ import { Module } from "@nestjs/common"; -import { transferController } from "./transfer.controller"; -import { transferService } from "./transfer.service"; +import { TransferController } from "./transfer.controller"; +import { TransferService } from "./transfer.service"; @Module({ imports: [], - controllers: [transferController], - providers: [transferService], + controllers: [TransferController], + providers: [TransferService], }) -export class transferModule {} +export class TransferModule {} diff --git a/data_migration_tools/server/src/features/transfer/transfer.service.ts b/data_migration_tools/server/src/features/transfer/transfer.service.ts index 70b5d26..24f93de 100644 --- a/data_migration_tools/server/src/features/transfer/transfer.service.ts +++ b/data_migration_tools/server/src/features/transfer/transfer.service.ts @@ -22,9 +22,9 @@ import { registInputDataResponse } from "./types/types"; import fs from "fs"; @Injectable() -export class transferService { +export class TransferService { constructor() {} - private readonly logger = new Logger(transferService.name); + private readonly logger = new Logger(TransferService.name); /** * Regist Data