Some checks failed
validate / lint (push) Failing after 2s
- Serialize every mutating command (recover, renew, register, rewrite-config, pause, resume, state-reset) on the shared lock, acquired BEFORE state is read rather than after: reading first and locking only around the write let a slower command silently clobber whatever a faster one wrote in between — in particular, an operator pause could be lost to an in-flight recovery pass that read state before the pause ran and only saved its own copy back afterwards. - Fix emergency_close() to reposition its VLAN 50 DROP to the first effective FORWARD position when it exists but has been pushed down by something else (e.g. an out-of-band ufw reload) — a bare `-C` existence check said nothing about position. - Tighten wait_for_verified()'s handshake freshness check from >= to > since_epoch: wg show and since_epoch are both whole seconds, so a handshake at exactly the same second as since_epoch is indistinguishable from a stale, pre-activation one and must not count as proof of a new one. - Fix the Ansible config-validation task to fail on any exit code outside status's three documented health exits (0/1/2), not just on 5 — verified live against the real program (no wg/ip/iptables on this dev machine reproduces the "nothing configured yet" first-run case; status correctly returns 1, and broken/missing config.json correctly returns 5 and is now caught). - Correct the live fault-injection drill in the role README: port 1337 is only the addKey registration API port, not the tunnel's own WireGuard UDP endpoint (derive that from `wg show pia-wg endpoints` instead), and make the packet-capture check direction-aware (`tcpdump -Q out`) so it can't conflate a real egress leak with VLAN 50's normal inbound arrival on enp1s0. Added 6 tests (86 total, all passing): emergency-close repositioning past a preceding ACCEPT, pause/resume blocking on an in-flight lock holder and surviving into a subsequent recovery pass, and the handshake boundary at exactly/one-second-either-side of since_epoch. yamllint, ansible-playbook --syntax-check, and ansible-lint (diffed against main — no new finding categories) all pass. No live changes; nothing pushed to main. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
20 lines
721 B
Django/Jinja
20 lines
721 B
Django/Jinja
# Managed by Ansible (role: pia-gateway). Do not edit by hand.
|
|
#
|
|
# One bounded recovery pass (files/pia_gateway.py `recover`). Exit codes 1
|
|
# (unhealthy, decision made) and 3 (safety drift handled with an emergency
|
|
# close + alert) are normal outcomes, not unit failures — only a crash or a
|
|
# corrupt state file (2) is, and that triggers the OnFailure notifier.
|
|
[Unit]
|
|
Description=PIA gateway automatic recovery pass
|
|
After=pia-killswitch.service network-online.target
|
|
Wants=network-online.target
|
|
OnFailure=pia-gateway-onfailure.service
|
|
|
|
[Service]
|
|
Type=oneshot
|
|
ExecStart={{ pia_gateway_program }} recover
|
|
SuccessExitStatus=1 3
|
|
TimeoutStartSec={{ (pia_recovery_max_duration_sec | int) + 300 }}
|
|
LimitCORE=0
|
|
PrivateTmp=yes
|