実態に合わせたメソッド名と変数名のリファクタリング

This commit is contained in:
mori.k 2025-06-17 14:30:10 +09:00
parent 28d8fe1133
commit 50c0ea95b3

View File

@ -115,10 +115,10 @@ class DcfInstMergeIO(JskultBatchEntrypoint):
# DCF施設削除新規マスタ出力 # DCF施設削除新規マスタ出力
logger.info('DCF施設削除新規マスタ出力を開始します。') logger.info('DCF施設削除新規マスタ出力を開始します。')
dcf_inst_merge_all_records = self._select_dcf_inst_merge_all(db) dcf_inst_merge_records = self._select_dcf_inst_merge(db)
file_path = self._make_csv_data( file_path = self._make_csv_data(
self.environment.DCF_INST_MERGE_SEND_FILE_NAME, self.environment.DCF_INST_MERGE_SEND_FILE_NAME,
dcf_inst_merge_all_records) dcf_inst_merge_records)
# CSVをS3にアップロード # CSVをS3にアップロード
self._upload_dcf_inst_merge_csv_file( self._upload_dcf_inst_merge_csv_file(
@ -284,7 +284,7 @@ class DcfInstMergeIO(JskultBatchEntrypoint):
return return
def _select_dcf_inst_merge_all(self, db: Database) -> tuple[bool, list[dict]]: def _select_dcf_inst_merge(self, db: Database) -> tuple[bool, list[dict]]:
try: try:
sql = """\ sql = """\
SELECT SELECT
@ -302,8 +302,8 @@ class DcfInstMergeIO(JskultBatchEntrypoint):
FROM FROM
src07.dcf_inst_merge src07.dcf_inst_merge
""" """
dcf_inst_merge_all_records = db.execute_select(sql) dcf_inst_merge_records = db.execute_select(sql)
return dcf_inst_merge_all_records return dcf_inst_merge_records
except Exception as e: except Exception as e:
raise BatchOperationException(e) raise BatchOperationException(e)