From 5f508ad1238794a89d2845b672c9b8810daab8a8 Mon Sep 17 00:00:00 2001 From: "shimoda.m@nds-tyo.co.jp" Date: Tue, 18 Apr 2023 18:26:43 +0900 Subject: [PATCH] =?UTF-8?q?fix:=20disconnect=E3=80=81commit=E3=82=92?= =?UTF-8?q?=E5=91=BC=E3=81=B6=E4=BD=8D=E7=BD=AE=E3=81=8C=E3=81=8A=E3=81=8B?= =?UTF-8?q?=E3=81=97=E3=81=84=E3=81=AE=E3=81=A7=E4=BF=AE=E6=AD=A3?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../src/batch/ultmarc/ultmarc_process.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/ecs/jskult-batch-daily/src/batch/ultmarc/ultmarc_process.py b/ecs/jskult-batch-daily/src/batch/ultmarc/ultmarc_process.py index 0fde5cf7..83433bda 100644 --- a/ecs/jskult-batch-daily/src/batch/ultmarc/ultmarc_process.py +++ b/ecs/jskult-batch-daily/src/batch/ultmarc/ultmarc_process.py @@ -98,11 +98,7 @@ def _import_to_ultmarc_table(dat_file: DatFile): log_message = ','.join([f'"{r}"' for r in record]) logger.warning(f'ERROR_LINE: {log_message}') dat_file.count_up_error() - # すべての行を登録終えたらコミットする - db.commit() - db.disconnect() # 処理結果をログに出力する - logger.info('Transaction COMMIT') logger.info(f'ultmarc import process RESULT') logger.info(f'SUCCESS_COUNT={dat_file.success_count}') logger.info(f'ERROR_COUNT={dat_file.error_count}') @@ -111,8 +107,8 @@ def _import_to_ultmarc_table(dat_file: DatFile): # 1件でもエラーがあれば、通知用にログに出力する if dat_file.error_count > 0: logger.warning('取り込みに失敗した行があります。詳細は`ERROR_LINE:`の行を確認してください。') - except Exception as e: - raise e finally: + # 終了時に必ずコミットする + db.commit() db.disconnect() return