nik/newdwh2021
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat:レビュー指摘事項修正

Browse Source 
https://nds-tyo.backlog.com/git/NEWDWH2021/newsdwh2021/pullRequests/37#comment-1247549
https://nds-tyo.backlog.com/git/NEWDWH2021/newsdwh2021/pullRequests/37#comment-1247558
This commit is contained in:
shimoda.m@nds-tyo.co.jp 2022-07-11 09:58:58 +09:00
parent bb77ae9368
commit bd515960d9
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lambda/check-view-security-option/check-view-option/dto/no_security_option_view.py
View File

@ -5,3 +5,4 @@ from dataclasses import dataclass
class NoSecurityOptionView: class NoSecurityOptionView:
schema_name: str schema_name: str
table_name: str table_name: str
security_type: str

4
lambda/check-view-security-option/check-view-option/main.py
View File

@ -44,6 +44,7 @@ def handler(event, context):
# ④ Viewのオプションを確認するため、データを取得する # ④ Viewのオプションを確認するため、データを取得する
logger.info('I-04-01', 'Viewセキュリティオプション チェック開始') logger.info('I-04-01', 'Viewセキュリティオプション チェック開始')
check_result = fetch_view_security_options(connection, check_target_schemas) check_result = fetch_view_security_options(connection, check_target_schemas)
logger.debug('D-04-01', f'取得データ：{check_result}')
if len(check_result) == 0: if len(check_result) == 0:
logger.info('I-04-02', 'Viewセキュリティオプション 未設定のViewはありません。処理を終了します。') logger.info('I-04-02', 'Viewセキュリティオプション 未設定のViewはありません。処理を終了します。')
return return
@ -164,7 +165,8 @@ def fetch_view_security_options(connection: Database, check_target_schemas: list
select_view_security_option_sql = f""" select_view_security_option_sql = f"""
SELECT SELECT
TABLE_SCHEMA, TABLE_SCHEMA,
TABLE_NAME TABLE_NAME,
SECURITY_TYPE
FROM FROM
INFORMATION_SCHEMA.VIEWS INFORMATION_SCHEMA.VIEWS
WHERE WHERE