From bf59acf1525ce48471477b254193b196aa228166 Mon Sep 17 00:00:00 2001 From: "shimoda.m@nds-tyo.co.jp" Date: Tue, 2 Aug 2022 17:01:32 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20=E3=83=86=E3=82=B9=E3=83=88?= =?UTF-8?q?=E5=AF=BE=E8=B1=A1=E3=81=AE=E3=83=A2=E3=82=B8=E3=83=A5=E3=83=BC?= =?UTF-8?q?=E3=83=AB=E5=A4=89=E6=95=B0=E3=82=92sut=E3=81=AB=E7=B5=B1?= =?UTF-8?q?=E4=B8=80?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- ecs/crm-datafetch/tests/aws/test_s3.py | 32 +++++++++++++------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/ecs/crm-datafetch/tests/aws/test_s3.py b/ecs/crm-datafetch/tests/aws/test_s3.py index b6016b35..7153d2a0 100644 --- a/ecs/crm-datafetch/tests/aws/test_s3.py +++ b/ecs/crm-datafetch/tests/aws/test_s3.py @@ -28,9 +28,9 @@ class TestS3Resource: # Arrange s3_client.put_object(Bucket=bucket_name, Key='hogehoge/test.txt', Body=b'aaaaaaaaaaaaaaa') - # ActAssert - s3_resource = S3Resource(bucket_name) - actual = s3_resource.get_object('hogehoge/test.txt') + # Act + sut = S3Resource(bucket_name) + actual = sut.get_object('hogehoge/test.txt') # Assert assert actual == 'aaaaaaaaaaaaaaa' @@ -44,9 +44,9 @@ class TestS3Resource: Expects: オブジェクトがPUTできること """ - s3_resource = S3Resource(bucket_name) + sut = S3Resource(bucket_name) - s3_resource.put_object('hogehoge/test.txt', 'aaaaaaaaaaaaaaa') + sut.put_object('hogehoge/test.txt', 'aaaaaaaaaaaaaaa') actual = s3_client.get_object(Bucket=bucket_name, Key='hogehoge/test.txt') assert actual['Body'].read().decode('utf-8') == 'aaaaaaaaaaaaaaa' @@ -66,8 +66,8 @@ class TestS3Resource: s3_client.create_bucket(Bucket=for_copy_bucket) s3_client.put_object(Bucket=bucket_name, Key='hogehoge/test.txt', Body=b'aaaaaaaaaaaaaaa') - s3_resource = S3Resource(bucket_name) - s3_resource.copy(bucket_name, 'hogehoge/test.txt', for_copy_bucket, 'test.txt') + sut = S3Resource(bucket_name) + sut.copy(bucket_name, 'hogehoge/test.txt', for_copy_bucket, 'test.txt') actual = s3_client.get_object(Bucket=for_copy_bucket, Key='test.txt') assert actual['Body'].read() == b'aaaaaaaaaaaaaaa' @@ -102,8 +102,8 @@ class TestConfigBucket: monkeypatch.setattr('src.aws.s3.OBJECT_INFO_FILENAME', 'objects.json') s3_client.put_object(Bucket=bucket_name, Key=f'crm/objects.json', Body=b'aaaaaaaaaaaaaaa') - config_bucket = ConfigBucket() - actual = config_bucket.get_object_info_file() + sut = ConfigBucket() + actual = sut.get_object_info_file() assert actual == 'aaaaaaaaaaaaaaa' @@ -120,8 +120,8 @@ class TestConfigBucket: monkeypatch.setattr('src.aws.s3.LAST_FETCH_DATE_FOLDER', 'crm') s3_client.put_object(Bucket=bucket_name, Key=f'crm/Object.json', Body=b'aaaaaaaaaaaaaaa') - config_bucket = ConfigBucket() - actual = config_bucket.get_last_fetch_datetime_file('Object.json') + sut = ConfigBucket() + actual = sut.get_last_fetch_datetime_file('Object.json') assert actual == 'aaaaaaaaaaaaaaa' @@ -137,13 +137,13 @@ class TestConfigBucket: monkeypatch.setattr('src.aws.s3.CRM_CONFIG_BUCKET', bucket_name) monkeypatch.setattr('src.aws.s3.LAST_FETCH_DATE_FOLDER', 'crm') - config_bucket = ConfigBucket() - config_bucket.put_last_fetch_datetime_file('Object.json', 'aaaaaaaaaaaaaaa') + sut = ConfigBucket() + sut.put_last_fetch_datetime_file('Object.json', 'aaaaaaaaaaaaaaa') actual = s3_client.get_object(Bucket=bucket_name, Key=f'crm/Object.json') assert actual['Body'].read().decode('utf-8') == 'aaaaaaaaaaaaaaa' - def test_config_bucket_str(self, s3_test, s3_client, bucket_name, monkeypatch): + def test_sut_str(self, s3_test, s3_client, bucket_name, monkeypatch): """ Cases: 設定ファイル配置バケットを文字列化したとき、バケット名が取得できること @@ -154,6 +154,6 @@ class TestConfigBucket: """ monkeypatch.setattr('src.aws.s3.CRM_CONFIG_BUCKET', bucket_name) - config_bucket = ConfigBucket() + sut = ConfigBucket() - assert str(config_bucket) == bucket_name + assert str(sut) == bucket_name