nik/newdwh2021
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: テスト対象のモジュール変数をsutに統一

Browse Source
This commit is contained in:
shimoda.m@nds-tyo.co.jp 2022-08-02 17:01:32 +09:00
parent b3f3e30312
commit bf59acf152
1 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
ecs/crm-datafetch/tests/aws/test_s3.py
View File

@ -28,9 +28,9 @@ class TestS3Resource:
# Arrange
s3_client.put_object(Bucket=bucket_name, Key='hogehoge/test.txt', Body=b'aaaaaaaaaaaaaaa')
# ActAssert
s3_resource = S3Resource(bucket_name)
actual = s3_resource.get_object('hogehoge/test.txt')
# Act
sut = S3Resource(bucket_name)
actual = sut.get_object('hogehoge/test.txt')
# Assert
assert actual == 'aaaaaaaaaaaaaaa'
@ -44,9 +44,9 @@ class TestS3Resource:
Expects:
オブジェクトがPUTできること
"""
s3_resource = S3Resource(bucket_name)
sut = S3Resource(bucket_name)
s3_resource.put_object('hogehoge/test.txt', 'aaaaaaaaaaaaaaa')
sut.put_object('hogehoge/test.txt', 'aaaaaaaaaaaaaaa')
actual = s3_client.get_object(Bucket=bucket_name, Key='hogehoge/test.txt')
assert actual['Body'].read().decode('utf-8') == 'aaaaaaaaaaaaaaa'
@ -66,8 +66,8 @@ class TestS3Resource:
s3_client.create_bucket(Bucket=for_copy_bucket)
s3_client.put_object(Bucket=bucket_name, Key='hogehoge/test.txt', Body=b'aaaaaaaaaaaaaaa')
s3_resource = S3Resource(bucket_name)
s3_resource.copy(bucket_name, 'hogehoge/test.txt', for_copy_bucket, 'test.txt')
sut = S3Resource(bucket_name)
sut.copy(bucket_name, 'hogehoge/test.txt', for_copy_bucket, 'test.txt')
actual = s3_client.get_object(Bucket=for_copy_bucket, Key='test.txt')
assert actual['Body'].read() == b'aaaaaaaaaaaaaaa'
@ -102,8 +102,8 @@ class TestConfigBucket:
monkeypatch.setattr('src.aws.s3.OBJECT_INFO_FILENAME', 'objects.json')
s3_client.put_object(Bucket=bucket_name, Key=f'crm/objects.json', Body=b'aaaaaaaaaaaaaaa')
config_bucket = ConfigBucket()
actual = config_bucket.get_object_info_file()
sut = ConfigBucket()
actual = sut.get_object_info_file()
assert actual == 'aaaaaaaaaaaaaaa'
@ -120,8 +120,8 @@ class TestConfigBucket:
monkeypatch.setattr('src.aws.s3.LAST_FETCH_DATE_FOLDER', 'crm')
s3_client.put_object(Bucket=bucket_name, Key=f'crm/Object.json', Body=b'aaaaaaaaaaaaaaa')
config_bucket = ConfigBucket()
actual = config_bucket.get_last_fetch_datetime_file('Object.json')
sut = ConfigBucket()
actual = sut.get_last_fetch_datetime_file('Object.json')
assert actual == 'aaaaaaaaaaaaaaa'
@ -137,13 +137,13 @@ class TestConfigBucket:
monkeypatch.setattr('src.aws.s3.CRM_CONFIG_BUCKET', bucket_name)
monkeypatch.setattr('src.aws.s3.LAST_FETCH_DATE_FOLDER', 'crm')
config_bucket = ConfigBucket()
config_bucket.put_last_fetch_datetime_file('Object.json', 'aaaaaaaaaaaaaaa')
sut = ConfigBucket()
sut.put_last_fetch_datetime_file('Object.json', 'aaaaaaaaaaaaaaa')
actual = s3_client.get_object(Bucket=bucket_name, Key=f'crm/Object.json')
assert actual['Body'].read().decode('utf-8') == 'aaaaaaaaaaaaaaa'
def test_config_bucket_str(self, s3_test, s3_client, bucket_name, monkeypatch):
def test_sut_str(self, s3_test, s3_client, bucket_name, monkeypatch):
"""
Cases:
設定ファイル配置バケットを文字列化したとき、バケット名が取得できること
@ -154,6 +154,6 @@ class TestConfigBucket:
"""
monkeypatch.setattr('src.aws.s3.CRM_CONFIG_BUCKET', bucket_name)
config_bucket = ConfigBucket()
sut = ConfigBucket()
assert str(config_bucket) == bucket_name
assert str(sut) == bucket_name